Conversation
When using the daemon utility and flag YAZ_DAEMON_LOG_REOPEN to allow for SIGHUP to re-open log files, it would only work once as the SIGHUP handler action was cleared. Now it remains enabled, so that SIGHUP can be received multiple times.
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the SIGHUP signal handler for log file reopening would only work once. The issue was caused by using the deprecated signal() function which has platform-dependent behavior that may reset the handler to default after the first invocation.
Changes:
- Replaced
signal()withsigaction()for SIGHUP handler registration to ensure handler persists across multiple signal invocations - Added logging statement to track when SIGHUP is received
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sigemptyset(&sa.sa_mask); | ||
| sa.sa_handler = log_reopen_handler; | ||
| sa.sa_flags = 0; | ||
| sigaction(SIGHUP, &sa, 0); |
There was a problem hiding this comment.
The third argument to sigaction should be NULL instead of 0 for better code clarity. While 0 is technically valid, using NULL makes it explicit that this is a pointer argument and improves code readability.
Suggested change
| sigaction(SIGHUP, &sa, 0); | |
| sigaction(SIGHUP, &sa, NULL); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the daemon utility and flag YAZ_DAEMON_LOG_REOPEN to allow for SIGHUP to re-open log files, it would only work once as the SIGHUP handler action was cleared. Now it remains enabled, so that SIGHUP can be received multiple times.